{{ message }}
Repository navigation
improvement(desktop, executions): fix desktop update script and throw error when thinking enabled on stream false - #6578
Merged
Merged
Conversation
Sg312
changed the title
Contributor
Greptile SummaryThis PR tightens workflow-execution validation for agent-event options and improves desktop update-channel resolution behind reverse proxies.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking recommendation to avoid trusting forwarded hostnames unless the deployment guarantees they are sanitized by a trusted proxy. The workflow validation and generated contract are coordinated, while desktop channel selection can silently skip origin updates in deployments that preserve or supply an incorrect forwarded hostname. Files Needing Attention: apps/sim/app/api/desktop/update/latest-mac.yml/route.ts
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix desktop update script and throw error when thinking enabled on stream false
Type of Change
Testing
Manual
Checklist