fix(editor): keep a retry number field's value when it is blurred unt…

…ouched Committing on blur normalized the draft unconditionally, and an untouched field's draft is null — which normalizes to the default. Focusing and leaving Max tries silently reset a configured 5 back to 3.
waleedlatif1 · Aug 10, 2026 · Aug 10, 2026 · Aug 10, 2026 · Aug 10, 2026 · Aug 10, 2026
commit df021b32b5523f8967f520f0e2feade38545b9e7
diff --git a/...wId]/components/panel/components/editor/components/retry-settings/retry-settings.test.tsx b/...wId]/components/panel/components/editor/components/retry-settings/retry-settings.test.tsx
@@ -0,0 +1,55 @@
+/**
+ * @vitest-environment jsdom
+ */
+import { act } from 'react'
+import { createRoot, type Root } from 'react-dom/client'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { RetrySettings } from './retry-settings'
+
+const policy = { enabled: true as const, maxTries: 5, waitBetweenTriesMs: 2000 }
+
+let container: HTMLDivElement
+let root: Root
+
+beforeEach(() => {
+  container = document.createElement('div')
+  document.body.appendChild(container)
+  root = createRoot(container)
+})
+
+afterEach(() => {
+  act(() => root.unmount())
+  container.remove()
+})
+
+function renderSettings(props: Partial<Parameters<typeof RetrySettings>[0]> = {}) {
+  const onChange = vi.fn()
+  act(() => {
+    root.render(<RetrySettings retry={policy} disabled={false} onChange={onChange} {...props} />)
+  })
+  return { onChange }
+}
+
+const field = (id: string) => container.querySelector<HTMLInputElement>(`#${id}`)
+
+describe('RetrySettings', () => {
+  it('leaves a configured value alone when the field is blurred untouched', () => {
+    const { onChange } = renderSettings()
+    const maxTries = field('block-retry-max-tries')!
+    expect(maxTries.value).toBe('5')
+
+    act(() => {
+      maxTries.dispatchEvent(new FocusEvent('focusout', { bubbles: true }))
+    })
+
+    expect(onChange).not.toHaveBeenCalled()
+    expect(field('block-retry-max-tries')!.value).toBe('5')
+  })
+
+  it('renders only the switch while retry is off', () => {
+    renderSettings({ retry: { ...policy, enabled: false } })
+
+    expect(field('block-retry-enabled')).not.toBeNull()
+    expect(field('block-retry-max-tries')).toBeNull()
+  })
+})
diff --git a/...rkflowId]/components/panel/components/editor/components/retry-settings/retry-settings.tsx b/...rkflowId]/components/panel/components/editor/components/retry-settings/retry-settings.tsx
@@ -48,6 +48,8 @@ function RetryNumberField({
   const [draft, setDraft] = useState<string | null>(null)
 
   const commit = () => {
+    /** Untouched field: nothing was typed, so there is nothing to normalize or write. */
+    if (draft === null) return
     const next = normalize(draft)
     setDraft(null)
     if (next !== value) onCommit(next)