fix(onepassword): close output-parity and doc-string gaps from final …

…audit - restore a deprecated no-op 'response' output so pre-existing saved workflows referencing it fail soft (empty) instead of hard-erroring now that per-operation outputs replace it - add missing block outputs (urls, favorite, version, state, lastEditedBy) for get/create/replace/update item so all real FULL_ITEM fields are discoverable as <Block.field> references - hide Connect Server credential fields for Resolve Secret (Service Account only) instead of leaving them selectable and silently ignored - correct two doc-string enum lists that advertised values the API doesn't return (vault type TRANSFER, item state DELETED)
simstudioai · waleedlatif1 · Jul 2, 2026 · Jul 2, 2026 · Jul 2, 2026 · Jul 2, 2026
commit 5a1d5359a5a03ac8b8e20aaf4d1e704be0440ac2
diff --git a/apps/sim/blocks/blocks/onepassword.ts b/apps/sim/blocks/blocks/onepassword.ts
@@ -57,17 +57,33 @@ export const OnePasswordBlock: BlockConfig = {
       title: 'Server URL',
       type: 'short-input',
       placeholder: 'http://localhost:8080',
-      required: { field: 'connectionMode', value: 'connect' },
-      condition: { field: 'connectionMode', value: 'connect' },
+      required: {
+        field: 'connectionMode',
+        value: 'connect',
+        and: { field: 'operation', value: 'resolve_secret', not: true },
+      },
+      condition: {
+        field: 'connectionMode',
+        value: 'connect',
+        and: { field: 'operation', value: 'resolve_secret', not: true },
+      },
     },
     {
       id: 'apiKey',
       title: 'Connect Token',
       type: 'short-input',
       placeholder: 'Enter your 1Password Connect token',
       password: true,
-      required: { field: 'connectionMode', value: 'connect' },
-      condition: { field: 'connectionMode', value: 'connect' },
+      required: {
+        field: 'connectionMode',
+        value: 'connect',
+        and: { field: 'operation', value: 'resolve_secret', not: true },
+      },
+      condition: {
+        field: 'connectionMode',
+        value: 'connect',
+        and: { field: 'operation', value: 'resolve_secret', not: true },
+      },
     },
     {
       id: 'secretReference',
@@ -294,6 +310,11 @@ Return ONLY valid JSON - no explanations, no markdown code blocks.`,
   },
 
   outputs: {
+    response: {
+      type: 'json',
+      description:
+        'Deprecated — kept for backward compatibility with workflows saved before per-operation outputs were added below. Never populated; use the operation-specific outputs instead.',
+    },
     vaults: {
       type: 'json',
       description:
@@ -326,7 +347,7 @@ Return ONLY valid JSON - no explanations, no markdown code blocks.`,
     },
     type: {
       type: 'string',
-      description: 'Vault type (USER_CREATED, PERSONAL, EVERYONE, TRANSFER)',
+      description: 'Vault type (USER_CREATED, PERSONAL, or EVERYONE)',
       condition: { field: 'operation', value: 'get_vault' },
     },
     title: {
@@ -386,6 +407,46 @@ Return ONLY valid JSON - no explanations, no markdown code blocks.`,
         value: ['get_item', 'create_item', 'replace_item', 'update_item'],
       },
     },
+    urls: {
+      type: 'json',
+      description: 'URLs associated with the item [{href, label, primary}]',
+      condition: {
+        field: 'operation',
+        value: ['get_item', 'create_item', 'replace_item', 'update_item'],
+      },
+    },
+    favorite: {
+      type: 'boolean',
+      description: 'Whether the item is favorited',
+      condition: {
+        field: 'operation',
+        value: ['get_item', 'create_item', 'replace_item', 'update_item'],
+      },
+    },
+    version: {
+      type: 'number',
+      description: 'Item version number',
+      condition: {
+        field: 'operation',
+        value: ['get_item', 'create_item', 'replace_item', 'update_item'],
+      },
+    },
+    state: {
+      type: 'string',
+      description: 'Item state (ARCHIVED, or absent/null when active)',
+      condition: {
+        field: 'operation',
+        value: ['get_item', 'create_item', 'replace_item', 'update_item'],
+      },
+    },
+    lastEditedBy: {
+      type: 'string',
+      description: 'ID of the last editor',
+      condition: {
+        field: 'operation',
+        value: ['get_item', 'create_item', 'replace_item', 'update_item'],
+      },
+    },
     createdAt: {
       type: 'string',
       description: 'Creation timestamp',

diff --git a/apps/sim/tools/onepassword/get_vault.ts b/apps/sim/tools/onepassword/get_vault.ts
@@ -99,7 +99,7 @@ export const getVaultTool: ToolConfig<OnePasswordGetVaultParams, OnePasswordGetV
     items: { type: 'number', description: 'Number of items in the vault' },
     type: {
       type: 'string',
-      description: 'Vault type (USER_CREATED, PERSONAL, EVERYONE, TRANSFER)',
+      description: 'Vault type (USER_CREATED, PERSONAL, or EVERYONE)',
     },
     createdAt: { type: 'string', description: 'Creation timestamp', optional: true },
     updatedAt: { type: 'string', description: 'Last update timestamp', optional: true },

diff --git a/apps/sim/tools/onepassword/list_items.ts b/apps/sim/tools/onepassword/list_items.ts
@@ -128,7 +128,7 @@ export const listItemsTool: ToolConfig<OnePasswordListItemsParams, OnePasswordLi
           version: { type: 'number', description: 'Item version number' },
           state: {
             type: 'string',
-            description: 'Item state (ARCHIVED or DELETED)',
+            description: 'Item state (ARCHIVED, or absent/null when active)',
             optional: true,
           },
           createdAt: { type: 'string', description: 'Creation timestamp', optional: true },

diff --git a/apps/sim/tools/onepassword/list_vaults.ts b/apps/sim/tools/onepassword/list_vaults.ts
@@ -97,7 +97,7 @@ export const listVaultsTool: ToolConfig<
           items: { type: 'number', description: 'Number of items in the vault' },
           type: {
             type: 'string',
-            description: 'Vault type (USER_CREATED, PERSONAL, EVERYONE, TRANSFER)',
+            description: 'Vault type (USER_CREATED, PERSONAL, or EVERYONE)',
           },
           createdAt: { type: 'string', description: 'Creation timestamp', optional: true },
           updatedAt: { type: 'string', description: 'Last update timestamp', optional: true },

diff --git a/apps/sim/tools/onepassword/utils.ts b/apps/sim/tools/onepassword/utils.ts
@@ -89,7 +89,11 @@ export const FULL_ITEM_OUTPUTS: Record<
   favorite: { type: 'boolean', description: 'Whether the item is favorited' },
   tags: { type: 'array', description: 'Item tags' },
   version: { type: 'number', description: 'Item version number' },
-  state: { type: 'string', description: 'Item state (ARCHIVED or DELETED)', optional: true },
+  state: {
+    type: 'string',
+    description: 'Item state (ARCHIVED, or absent/null when active)',
+    optional: true,
+  },
   fields: {
     type: 'array',
     description: 'Item fields including secrets',