feat(mothership): add secrets input in chat by Sg312 · Pull Request #5274 · simstudioai/sim · GitHub
Skip to content

feat(mothership): add secrets input in chat#5274

Merged
Sg312 merged 3 commits into
stagingfrom
dev
Jun 30, 2026
Merged

feat(mothership): add secrets input in chat#5274
Sg312 merged 3 commits into
stagingfrom
dev

Conversation

@Sg312

@Sg312 Sg312 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add secrets input in chat

Type of Change

  • New feature

Testing

Manual

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds inline secret entry support to chat messages. The main changes are:

  • A new secret_input credential tag type.
  • Validation for secret input name and optional scope.
  • A chat-rendered SecretInput widget that saves to personal or workspace environments.
  • Permission gating for secret inputs and credential connect links.

Confidence Score: 4/5

The chat secret save path needs fixes before merging.

  • Chat-entered credentials default to workspace storage when scope is omitted.
  • Personal secret saves can overwrite newer keys because they send a full map from cached state.
  • Credential connect links may disappear for read-only users when the target flow is personal.

apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx

Security Review

The new chat secret input can save a manually pasted credential to the shared workspace environment by default. User-provided API keys should stay user-only unless a trusted server path explicitly opts into workspace scope.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx Adds parsing and rendering for chat secret inputs, with new environment-save behavior and permission gates.

Reviews (1): Last reviewed commit: "improvement(secrets): special tags impro..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Jun 29, 2026
View reviewed changes
Comment thread ...space/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx

@greptile-apps greptile-apps Bot Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 security Chat Secrets Default Shared

When a chat secret_input tag omits scope, this defaults the pasted credential to workspace and saves it through the shared workspace environment path. A user-provided API key entered in chat can therefore become a workspace secret instead of a user-only credential, exposing the key name and making the secret available to workspace-scoped flows.

Rule Used: API keys and other user-provided credentials shoul... (source)

Learned From
simstudioai/sim#2133

Comment thread ...space/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx
Comment thread ...space/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx
Sg312 added 2 commits June 29, 2026 16:44
@Sg312
feat(mship): secrets prompting
c2c5f80 
t# with '#' will be ignored, and an empty message aborts the commit.
@Sg312
improvement(secrets): special tags improvement
89da624
@Sg312 Sg312 merged commit 8925334 into staging Jun 30, 2026
29 checks passed
@waleedlatif1 waleedlatif1 mentioned this pull request Jun 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Sg312