fix(knowledge): document tag filter matches case-insensitively and by calendar day by waleedlatif1 · Pull Request #5221 · simstudioai/sim · GitHub
Skip to content

fix(knowledge): document tag filter matches case-insensitively and by calendar day#5221

Merged
waleedlatif1 merged 1 commit into
stagingfrom
kb-tag-filter
Jun 26, 2026
Merged

fix(knowledge): document tag filter matches case-insensitively and by calendar day#5221
waleedlatif1 merged 1 commit into
stagingfrom
kb-tag-filter

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Knowledge Base document-list tag filtering returned empty results in two cases: text filters used case-sensitive equality (any casing difference missed), and date filters compared a YYYY-MM-DD value against a midnight-UTC timestamp so date equals never matched a stored timestamp.
  • Aligned the document-list filter with the existing knowledge search filter semantics: text eq/neq are now case-insensitive (LOWER), and date comparisons run on the calendar day (::date).
  • Extracted the predicate builder out of the large documents service into its own single-responsibility tag-filter.ts module with unit coverage.
  • Tidied the filter popover's secondary labels to the caption text size for chip-design consistency.

Type of Change

  • Bug fix

Testing

  • Added unit tests for the tag-filter predicate builder (text case-insensitivity, calendar-day date comparison, range bounds, validation/guard paths, number/boolean parsing).
  • Existing documents route tests pass; typecheck and API-validation gate pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
fix(knowledge): document tag filter matches case-insensitively and by…
74b96a9 
… calendar day

The Knowledge Base document list applied tag filters with case-sensitive text
equality and compared date tags against a midnight-UTC timestamp, so text
filters missed on any casing difference and date eq never matched a stored
timestamp — both silently returned empty results.

Align the document-list filter with the knowledge search filter semantics:
text eq/neq are now case-insensitive (LOWER) and date comparisons run on the
calendar day (::date). Extract the predicate builder into its own
single-responsibility module with unit coverage, and tidy the filter popover's
secondary labels to the caption text size for chip-design consistency.
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

@cursor

cursor Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes query semantics for document listing (users may see more matches); logic is tested and mirrors existing search filters, but incorrect edge cases could still affect filtered bulk views.

Overview
Fixes knowledge base document list tag filters that often returned no rows: text eq/neq were case-sensitive, and date equals compared a YYYY-MM-DD input to full timestamps so same-day values did not match.

Tag predicate building moves from documents/service into tag-filter.ts, with case-insensitive text equality (LOWER) and calendar-day date comparisons (::date), aligned with knowledge search filter behavior. Invalid date strings and incomplete between ranges are skipped instead of building bad SQL. The documents API imports TagFilterCondition from the new module.

Vitest coverage was added for the predicate builder. The KB filter popover uses text-caption instead of text-xs on secondary labels.

Reviewed by Cursor Bugbot for commit 74b96a9. Configure here.

@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes knowledge document tag filtering and moves the predicate logic into its own module. The main changes are:

  • Case-insensitive text equality and inequality for document tag filters.
  • Calendar-day date comparisons for document tag filters.
  • A new tag-filter.ts helper with unit tests.
  • Updated tag filter type imports in the API route and documents service.
  • Small text-size updates in the knowledge filter popover.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/lib/knowledge/documents/tag-filter.ts Adds the extracted document tag filter predicate builder with case-insensitive text matching and calendar-day date matching.
apps/sim/lib/knowledge/documents/service.ts Replaces the inline tag filter builder with imports from the new helper module.
apps/sim/app/api/knowledge/[id]/documents/route.ts Updates the TagFilterCondition type import to the new helper module.
apps/sim/lib/knowledge/documents/tag-filter.test.ts Adds tests for text, date, number, boolean, and invalid tag filter inputs.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx Updates secondary labels and clear buttons in the knowledge filter UI to use text-caption.

Reviews (1): Last reviewed commit: "fix(knowledge): document tag filter matc..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 365d8be into staging Jun 26, 2026
16 checks passed
@waleedlatif1 waleedlatif1 deleted the kb-tag-filter branch June 26, 2026 17:18
This was referenced Jun 26, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1