{{ message }}
Merged
Conversation
Member
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a SIMDJSON_INSTALL CMake option to control whether simdjson defines install rules, primarily to prevent unintended installs when simdjson is consumed via add_subdirectory() / FetchContent.
Changes:
- Introduces
SIMDJSON_INSTALLand gates all install/package export rules behind it. - Sets different defaults for
SIMDJSON_INSTALLdepending on whether simdjson is the top-level project.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a SIMDJSON_INSTALL cmake option to avoid installing the targets by default if the repo is imported with add_subdirectory or cmake's fetchcontet.
Description
Before all targets from simdjson would be installed together with the package of the calling repo (including static libraries and cmake files). With this it is off by default but can be turned on. This is the same approach used by fmt.
In case the repo is imported the value of the option is based on wether the libraries are static or not (it doesn't make sanse to install a static lib). Also this installed files the would confilct with packages imorting the repo the same way.
Type of change
How to verify / test
git clone https://github.com/simdjson/cmake_demo_single_file.gitcpackto get a debBefore:
After:
Checklist before submitting