{{ message }}
Fix removing application auth tokens#213
Closed
jmcarp wants to merge 1 commit into
Closed
Conversation
Owner
There was a problem hiding this comment.
I'm moving away from functions like this. Functions should have a single responsibility and nested if statements are the devil. ;) I'll leave better review later after I get out of work. Thanks for sending this!
Contributor
Author
There was a problem hiding this comment.
Happy to revise this once I'm out of work myself.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes revoking auth tokens for an application. Per the API docs,
GitHub::revoke_authorizationandGitHub::revoke_authorizationsneed to pass the application key and secret through basic auth.