{{ message }}
Cleaned Dockerfile CMD entrypoints to make it easier to extend or buil… - #590
Open
pathtofile wants to merge 2 commits into
Open
Cleaned Dockerfile CMD entrypoints to make it easier to extend or buil…#590pathtofile wants to merge 2 commits into
pathtofile wants to merge 2 commits into
Conversation
added 2 commits
December 12, 2022 14:27
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned Dockerfile CMD entrypoints to make it easier to extend or build on top of built image.
In some situations you might want to run extra setup inside the container prior to qemu, or build on top of the built docker image using e.g.
FROM sickcodes/docker-osx:naked.Without this PR, when you change the CMD you'd need to also re-implement all of the checks and setup done by the original CMD.
With this PR, you can first call your own script first, then call
bash -c entrypoint.shafter your code, and optionally have some post-QEMU code after the VM has shut down.