{{ message }}
Report forgotten errors from 'mv'#879
Open
vgalka-sl wants to merge 2 commits into
Open
Conversation
nfischer
requested changes
Jul 23, 2018
| cp('-r', src, thisDest); | ||
| rm('-rf', src); | ||
| } else { | ||
| common.error(e.message, { continue: true }); |
Member
There was a problem hiding this comment.
Could you catch a specific e.code and output a message like mv: cannot move 'foo/a/file.js' to 'bar/a/file.js': No such file or directory?
Also, could you add an else branch with throw e? The distinction is that we only want to use common.error() for expected error conditions, and would prefer to fail loudly with an exception for unexpected conditions (so that we can fix these as they're reported).
nfischer
added
fix
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #878.