[cp] Add test for cycle symlink by wafuwafu13 · Pull Request #1045 · shelljs/shelljs · GitHub
Skip to content

[cp] Add test for cycle symlink#1045

Open
wafuwafu13 wants to merge 3 commits into
shelljs:mainfrom
wafuwafu13:cpcheckcycle-test
Open

[cp] Add test for cycle symlink#1045
wafuwafu13 wants to merge 3 commits into
shelljs:mainfrom
wafuwafu13:cpcheckcycle-test

Conversation

@wafuwafu13

Copy link
Copy Markdown

Related: #739

Comment thread test/cp.js

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete it because it doesn't create symlinks to check for cycle.

@wafuwafu13

wafuwafu13 commented Sep 23, 2021

Copy link
Copy Markdown
Author

test passes in my local environment... 😓

@nfischer nfischer added the test label Jan 27, 2022
@nfischer

Copy link
Copy Markdown
Member

Could you rebase? I recently updated CI to use GitHub actions instead. This may be more reliable than the old environment.

@codecov-commenter

codecov-commenter commented Feb 1, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (9a0e5f6) to head (b535d24).
⚠️ Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   97.19%   97.04%   -0.15%     
==========================================
  Files          36       36              
  Lines        1354     1354              
==========================================
- Hits         1316     1314       -2     
- Misses         38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wafuwafu13

Copy link
Copy Markdown
Author

I don't know how to solve this problem in windows, so close

@wafuwafu13 wafuwafu13 closed this Feb 1, 2022
@nfischer

nfischer commented Feb 4, 2022

Copy link
Copy Markdown
Member

Thanks for trying the rebase. Looks like the error message from https://github.com/shelljs/shelljs/runs/5018531671?check_suite_focus=true is:

cp » Test with cycle symlink

  D:\a\shelljs\shelljs\tmp04812076144037267068[653](https://github.com/shelljs/shelljs/runs/5018531671?check_suite_focus=true#step:5:653)06818777819\test\cp.js:635

  Value is not falsy:

  'cp: cannot create directory \'new\': No such file or directory'

  _utils.default.skipOnWinForEPERM (test/cp.js:635:9)
  Object.skipOnWinForEPERM (test/utils/utils.js:31:5)
  t (test/cp.js:629:11)

I wonder if new is a reserved word on Windows, or maybe we just can't create the dir for some reason?

@wafuwafu13 wafuwafu13 reopened this Feb 6, 2022
@wafuwafu13

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants