{{ message }}
Preserve precision grid size when copying geometries#2465
Open
apoorva-01 wants to merge 1 commit into
Open
Conversation
deepcopy and pickle went through WKB only, which drops the grid size set by set_precision. Store it alongside the WKB and re-apply it on load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deepcopyand pickle lose the precision grid size fromset_precision(get_precisioncomes back0.0). The reduce methods only store WKB, and WKB doesn't carry the grid size.So I stash
get_precisionnext to the WKB and re-apply it on unpickle. Regression test intest_misc.py, plus a CHANGES entry. Suite's green.One call I'd like your take on: @jorisvandenbossche noted set_precision might change the geometry, and it does for polygons. The default mode renormalizes the ring start vertex (geometry's still equal, just a different starting point) but keeps Z and M.
mode="pointwise"avoids that but drops M, so I went with the default to not lose data. Fine as is, or would you rather have a lower-level grid-size setter?Fixes #2073