script: retrieve fetch options and base url from the active script for timer scripts by Gae24 · Pull Request #44741 · servo/servo · GitHub
Skip to content

script: retrieve fetch options and base url from the active script for timer scripts#44741

Merged
jdm merged 2 commits into
servo:mainfrom
Gae24:timers-active-script
May 5, 2026
Merged

script: retrieve fetch options and base url from the active script for timer scripts#44741
jdm merged 2 commits into
servo:mainfrom
Gae24:timers-active-script

Conversation

@Gae24

@Gae24 Gae24 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Use the active script's fetch options and base url according to spec, fixing dynamic imports inside timers scripts.
Since the active script is no longer available once invoke is called, these values are stored during set_timeout_or_interval.

Testing: New passes, expectations updated.

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@Gae24 Gae24 requested a review from gterzian as a code owner May 5, 2026 10:46
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 5, 2026

@jdm jdm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Comment thread components/script/timers.rs
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label May 5, 2026
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 5, 2026
@jdm jdm added this pull request to the merge queue May 5, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 5, 2026
Merged via the queue into servo:main with commit 13210b2 May 5, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 5, 2026
@Gae24 Gae24 deleted the timers-active-script branch May 7, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants