script: Replace assert! to debug_assert! in sanitizer by nodelpit · Pull Request #44679 · servo/servo · GitHub
Skip to content

script: Replace assert! to debug_assert! in sanitizer#44679

Merged
kkoyung merged 1 commit into
servo:mainfrom
nodelpit:issue-44654
May 3, 2026
Merged

script: Replace assert! to debug_assert! in sanitizer#44679
kkoyung merged 1 commit into
servo:mainfrom
nodelpit:issue-44654

Conversation

@nodelpit

@nodelpit nodelpit commented May 2, 2026

Copy link
Copy Markdown
Contributor

This change allows for better performance in production.

Testing: successful build, fmt, test-tidy, clippy
Fixes: #44654

This change allows for better performance in production.

Testing: successful build, fmt, test-tidy, clippy
Fixes: servo#44654

Signed-off-by: Noah Delpit <176803893+nodelpit@users.noreply.github.com>
@nodelpit nodelpit requested a review from gterzian as a code owner May 2, 2026 17:50
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 2, 2026

@kkoyung kkoyung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label May 3, 2026
@kkoyung kkoyung added this pull request to the merge queue May 3, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 3, 2026
Merged via the queue into servo:main with commit ccb02d8 May 3, 2026
34 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 3, 2026
@nodelpit nodelpit deleted the issue-44654 branch May 3, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change computational expensive assert! in sanitizer to debug_assert!

3 participants