Add two error messages to customElements.define by PuercoPop · Pull Request #44656 · servo/servo · GitHub
Skip to content

Add two error messages to customElements.define#44656

Merged
TimvdLippe merged 2 commits into
servo:mainfrom
PuercoPop:issue-40756-add-some-errors-to-custom-elements-define
May 1, 2026
Merged

Add two error messages to customElements.define#44656
TimvdLippe merged 2 commits into
servo:mainfrom
PuercoPop:issue-40756-add-some-errors-to-custom-elements-define

Conversation

@PuercoPop

Copy link
Copy Markdown
Contributor

Provided an error message for two scenarios:

  • When the custom element name is invalid
  • When the custom element name has already been registered.

Testing: Verified the behavior manually in devtools (`./mach run --devtools=6080)
Fixes: Part of #40756

PuercoPop added 2 commits May 1, 2026 00:57
Signed-off-by: Javier Olaechea <pirata@gmail.com>
…dy in use

Signed-off-by: Javier Olaechea <pirata@gmail.com>
@PuercoPop PuercoPop requested a review from gterzian as a code owner May 1, 2026 06:39
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 1, 2026

@TimvdLippe TimvdLippe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label May 1, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue May 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 1, 2026
Merged via the queue into servo:main with commit becf283 May 1, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants