iframe-proxy

Narfinger · 2026-04-29T10:42:51Z

As part of splitting up the Script crate this moves DomRefCell (and related) into script_bindings. Also it moves assert_in_script and assert_in_layout, similarly.
As the diff is quite large, the major files are

script_bindings/assert
script_binding/cell
script_binding/like

Testing: As this is moving things around and changing visibility compilation is the test.

github-actions · 2026-04-30T07:34:04Z

github-actions · 2026-04-30T08:05:20Z

Test results for linux-wpt from try job (#25153261302):

Flaky unexpected result (39)

TIMEOUT [expected OK] /_mozilla/mozilla/focus-scroll-when-visible.html
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 14 more unexpected results...
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = blob
```
assert_false: expected false got true
```
CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
OK /css/css-animations/event-order.tentative.html (#39000)
- PASS [expected FAIL] subtest: Same events on pseudo-elements follow the prescribed order
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
FAIL [expected PASS] /css/css-backgrounds/border-image-repeat-space-9.html
FAIL [expected PASS] /css/css-ui/appearance-button-001.html
FAIL [expected PASS] /css/css-ui/webkit-appearance-menulist-001.html
CRASH [expected OK] /fetch/api/cors/cors-cookies.any.html
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
CRASH [expected OK] /fetch/api/request/request-cache-default.any.worker.html
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html (#44028)
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/origin/api/origin-from-global.any.worker.html
OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- PASS [expected FAIL] subtest: opener of discarded auxiliary browsing context
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
CRASH [expected ERROR] /html/semantics/forms/the-select-element/customizable-select/select-appearance-button-after-span.html
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.html (#33948)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Module fetching failed"
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /infrastructure/testdriver/click_iframe.html
- FAIL [expected PASS] subtest: TestDriver click on a document in an iframe
```
Unhandled rejection: assert_unreached: click failed Reached unreachable code
```
TIMEOUT [expected OK] /infrastructure/testdriver/click_nested.html (#43887)
- NOTRUN [expected FAIL] subtest: TestDriver click method with multiple windows and nested iframe
OK /paint-timing/with-lcp/fcp-document-opacity-image.html (#43068)
- FAIL [expected PASS] subtest: Test that FCP after opacity change is not a larger value than LCP
```
assert_equals: First contentful paint marked too early.  expected 0 but got 1
```
PASS [expected FAIL] /png/apng/acTL-plays-one.html (#41218)
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
OK /sanitizer-api/sanitizer-inert-document.tentative.html (#44273)
- PASS [expected FAIL] subtest: Test whether setHTMLUnsafe loads the image.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
CRASH [expected OK] /webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/closed-audiocontext-construction.html
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
CRASH [expected ERROR] /workers/Worker-constructor-proto.any.serviceworker.html

Stable unexpected results that are known to be intermittent (19)

OK /IndexedDB/idbdatabase_deleteObjectStore.any.worker.html (#43776)
- FAIL [expected PASS] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
```
assert_unreached: rq_add.error (DataError) Reached unreachable code
```
TIMEOUT [expected OK] /_mozilla/mozilla/window-resize-event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
```
assert_equals: quoted fantasy matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-sans-serif (drawing text in a canvas)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/empty-payload.https.window.html (#35176)
- PASS [expected FAIL] subtest: fetchLater() accepts an empty POST request body of String in same-origin iframe.
- PASS [expected FAIL] subtest: fetchLater() accepts an empty POST request body of ArrayBuffer in same-origin iframe.
- PASS [expected FAIL] subtest: fetchLater() accepts an empty POST request body of URLSearchParams in same-origin iframe.
- PASS [expected FAIL] subtest: fetchLater() accepts an empty POST request body of Blob in same-origin iframe.
- PASS [expected FAIL] subtest: fetchLater() accepts an empty POST request body of File in same-origin iframe.
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-mode
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-204.html (#44521)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html (#44099)
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by submitButton.click()
```
Test timed out
```

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt;
&lt;img src="/media/poster.png" usemap="#map"&gt;
&lt;map n...

OK /html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm (#40626)
- PASS [expected FAIL] subtest: seek to Number.MAX_VALUE
TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/form-submit-iframe-then-location-navigate.html (#29634)
- TIMEOUT [expected FAIL] subtest: Verifies that location navigations take precedence when following form submissions.
```
Test timed out
```
OK /html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html (#44058)
- FAIL [expected PASS] subtest: Parse errors in different files should be reported depending on different roots
```
assert_not_equals: two different parse errors should be reported got disallowed value object "SyntaxError: expected expression, got '%'"
```
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- PASS [expected FAIL] subtest: Revoking a blob URL immediately after calling import will not fail
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload domInteractive > Original domInteractive
```
assert_true: Reload domInteractive &gt; Original domInteractive expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /resource-timing/buffer-full-then-increased.html (#44408)
- FAIL [expected PASS] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 1
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-reporting.html (#43737)
- FAIL [expected PASS] subtest: Trusted Type violation report: creating a forbidden-but-not-reported policy.
```
assert_equals: a single violation reported expected 1 but got 0
```
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.

github-actions · 2026-04-30T08:05:35Z

✨ Try run (#25153261302) succeeded.

Narfinger · 2026-04-30T09:19:30Z

Currently accountable_refcell is broken (and was probably broken for quite a whle) because the script uses Ref/RefMut from std::cell: and dom::bindings::cell (now script_bindings::cell) interchangeably which they are not under the feature flag.
Restoring this in this PR proved to be quite a bother so I leave it in the broken stage for now.

sagudev · 2026-04-30T10:03:44Z

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

Narfinger requested review from gterzian and sagudev as code owners April 29, 2026 10:42

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Apr 29, 2026

Narfinger force-pushed the move-domrefcell branch from de1801a to 6475a08 Compare April 29, 2026 10:46

servo-highfive removed the S-needs-rebase There are merge conflict errors. label Apr 29, 2026

Narfinger force-pushed the move-domrefcell branch from 4077f5e to 5a5bc5d Compare April 30, 2026 07:21

Narfinger added the T-linux-wpt Do a try run of the WPT label Apr 30, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 30, 2026

Narfinger force-pushed the move-domrefcell branch from 5a5bc5d to febccba Compare April 30, 2026 07:44

sagudev requested changes Apr 30, 2026

View reviewed changes

Comment thread components/script/dom/bindings/refcounted.rs

Comment thread components/script_bindings/Cargo.toml

servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 30, 2026

Narfinger force-pushed the move-domrefcell branch from febccba to 835f934 Compare April 30, 2026 08:56

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Apr 30, 2026

Narfinger force-pushed the move-domrefcell branch from 6225699 to e301865 Compare April 30, 2026 09:15

sagudev approved these changes Apr 30, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 30, 2026

move files

7fb49fa

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

Narfinger force-pushed the move-domrefcell branch from e301865 to 7fb49fa Compare May 4, 2026 08:16

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 4, 2026

sagudev added this pull request to the merge queue May 4, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 4, 2026

Merged via the queue into servo:main with commit 474ee17 May 4, 2026
33 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 4, 2026

Narfinger deleted the move-domrefcell branch May 4, 2026 12:29

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

script: Move DomRefCell, assert_in_* into script_bindings#44598

script: Move DomRefCell, assert_in_* into script_bindings#44598
sagudev merged 1 commit into
servo:mainfrom
Narfinger:move-domrefcell

Narfinger commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Narfinger commented Apr 30, 2026

Uh oh!

sagudev commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

Narfinger commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Narfinger commented Apr 30, 2026

Uh oh!

sagudev commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants