{{ message }}
script: Expose legacy table cellSpacing, cellPadding, and align DOM properties#43903
Merged
TimvdLippe merged 1 commit intoApr 3, 2026
Merged
Conversation
… DOM properties We support these setting these as attributes on the `<table>` element itself, so I suppose it also makes sense to support their DOM APIs as well. This trades a teensy bit of code for compatability with a some old web content. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Apr 3, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support these setting these as attributes on the
<table>elementitself, so I suppose it also makes sense to support their DOM APIs as
well. This trades a teensy bit of code for compatability with a some old
web content.
Testing: This causes a handful of reflection subtests to start passing. There
isn't much testing for the behavior of the attributes, but this is legacy
behavior so it sort of makes sense.