layout: Wrap Image related data in `ImageInfo` struct in `NodeExt` impl by shubhamg13 · Pull Request #42948 · servo/servo · GitHub
Skip to content

layout: Wrap Image related data in ImageInfo struct in NodeExt impl#42948

Merged
TimvdLippe merged 1 commit into
servo:mainfrom
shubhamg13:ImageInfo_dom
Mar 2, 2026
Merged

layout: Wrap Image related data in ImageInfo struct in NodeExt impl#42948
TimvdLippe merged 1 commit into
servo:mainfrom
shubhamg13:ImageInfo_dom

Conversation

@shubhamg13

@shubhamg13 shubhamg13 commented Mar 2, 2026

Copy link
Copy Markdown
Member

Encapsulating Image related data in ImageInfo in NodeExt impl.

Testing: This is just a little refactor. No change in behavior expected. Successful compilation is enough to verify.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026
@shubhamg13 shubhamg13 changed the title layout: Wrap Image related data in ImageInfo struct in NodeExt impl layout: Wrap Image related data in ImageInfo struct in NodeExt impl Mar 2, 2026
Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 2, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Mar 2, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2026
Merged via the queue into servo:main with commit 71974ea Mar 2, 2026
31 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 2, 2026
@shubhamg13 shubhamg13 deleted the ImageInfo_dom branch March 2, 2026 11:58
github-merge-queue Bot pushed a commit that referenced this pull request Mar 2, 2026
This just adds URL to pass to ImageFragment for LargestContentfulPaint
Entry

Rebased on: #42948

Testing: No expected change in behavior, Successful Compilation is
enough to verify.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
…pl (servo#42948)

Encapsulating Image related data in ImageInfo in NodeExt impl.

Testing: This is just a little refactor. No change in behavior expected.
Successful compilation is enough to verify.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
simonwuelker pushed a commit to simonwuelker/servo that referenced this pull request Mar 3, 2026
This just adds URL to pass to ImageFragment for LargestContentfulPaint
Entry

Rebased on: servo#42948

Testing: No expected change in behavior, Successful Compilation is
enough to verify.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
offline-ant pushed a commit to offline-ant/havi that referenced this pull request Jun 4, 2026
…pl (servo#42948)

Encapsulating Image related data in ImageInfo in NodeExt impl.

Testing: This is just a little refactor. No change in behavior expected.
Successful compilation is enough to verify.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
offline-ant pushed a commit to offline-ant/havi that referenced this pull request Jun 4, 2026
This just adds URL to pass to ImageFragment for LargestContentfulPaint
Entry

Rebased on: servo#42948

Testing: No expected change in behavior, Successful Compilation is
enough to verify.

Signed-off-by: Shubham Gupta <shubham.gupta@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants