{{ message }}
Make do an array#895
Merged
cdavernas merged 25 commits intoJun 13, 2024
Merged
Conversation
matthias-pichler
force-pushed
the
matthias-pichler/invalid-do-switch-894
branch
from
43d0fb2 to
a2d5cd2
Compare
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
matthias-pichler
force-pushed
the
matthias-pichler/invalid-do-switch-894
branch
from
ab2e14c to
ff4fb6e
Compare
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
matthias-pichler
requested review from
cdavernas and
ricardozanini
as code owners
Closed
Collaborator
Collaborator
Author
fjtirado
reviewed
Jun 12, 2024
cdavernas
requested changes
Jun 12, 2024
fjtirado
approved these changes
Jun 12, 2024
JBBianchi
approved these changes
Jun 12, 2024
ricardozanini
left a comment
ricardozanini
left a comment
Member
There was a problem hiding this comment.
LGTM. Great work, many thanks! Once we split the task section as pointed by @cdavernas I'll do another round.
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
matthias-pichler
force-pushed
the
matthias-pichler/invalid-do-switch-894
branch
from
603caed to
b5c71f1
Compare
JBBianchi
reviewed
Jun 12, 2024
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
JBBianchi
approved these changes
Jun 12, 2024
ricardozanini
approved these changes
Jun 12, 2024
cdavernas
approved these changes
Jun 13, 2024
cdavernas
left a comment
cdavernas
left a comment
Member
There was a problem hiding this comment.
Looks great to me! Many thanks ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please specify parts of this PR update:
Discussion or Issue link:
Closes #894
What this PR does:
do,try,catch.do,doinfor,beforeandafteran array of named tasksAdditional information:
Now the usage of
doboth inforTasks as well as sequential composite tasks lead to the result thatfortasks now also matched the schema of the composite sequential task. As discussed earlier this is because additional/unevaluated properties were not restricted. This lead to the error that afortask was also recognized as adotask and hence matched two schemas inoneOf... I therefore refactored the schema to distinguish between these and no allow additional properties