Create include array for zip step if undefined by miketheman · Pull Request #89 · serverless/serverless-python-requirements · GitHub
Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Create include array for zip step if undefined#89

Merged
dschep merged 1 commit into
serverless:masterfrom
miketheman:miketheman/implicit-include-zip
Oct 17, 2017
Merged

Create include array for zip step if undefined#89
dschep merged 1 commit into
serverless:masterfrom
miketheman:miketheman/implicit-include-zip

Conversation

@miketheman

Copy link
Copy Markdown
Contributor

Refs #16
Similar to 6c5523c

Signed-off-by: Mike Fiedler miketheman@gmail.com

Refs #16
Similar to 6c5523c

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Comment thread test.bats

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies here - I spent 15 minutes trying to get the right sed syntax for multiline in one expression before smashing my keyboard and writing the second expression.

@dschep dschep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! and no worries about the multiple expressions, that's the better solution anyway IMO 😉

@dschep dschep merged commit 1612878 into serverless:master Oct 17, 2017
dschep added a commit that referenced this pull request Oct 17, 2017
@miketheman miketheman deleted the miketheman/implicit-include-zip branch October 19, 2017 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants