{{ message }}
Fix: override wildcard glob pattern (**) in resolveFilePathsFromPatterns#5825
Merged
Merged
Conversation
pmuens
changed the title
pmuens
approved these changes
Feb 13, 2019
pmuens
left a comment
pmuens
left a comment
Contributor
There was a problem hiding this comment.
This is great! Thanks for taking a deeper dive into this and fixing it @svlapin 👍
I just tested it and it works great! Took more than 2 minutes vs. 2 1/2 seconds. This is awesome 👌
I just added a clarification comment to the code you changed so that others who might touch this won't change the order by accident. Also looked into potential test cases, but other than mocking globby there's no way to test this in a meaningful way...
Will merge once Travis agrees 
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Ability to override wildcard glob pattern by a negative
params.includeto avoid unnecessary traversal and get much faster glob matching during packaging in some cases.When
globbyis provided with an array of patterns, it adds all subsequent negative patterns asignoreoption of a particular task (source code here). However, that is not useful when the wildcard comes the last (as it is now) -ignorefor the relevant matching task is always empty.Putting the least specific pattern first makes it possible to override it with a subsequent negative one and avoid unnecessary traversal in e.g.
node_modules,.git, etc.Related to #4263, #5574.
How did you implement it:
Put wildcard pattern
**first inresolveFilePathsFromPatterns.How can we verify it:
Minimal example
Without this PR:
With this PR:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO