Add FrameworkId to stats by alexdebrie · Pull Request #4087 · serverless/serverless · GitHub
Skip to content

Add FrameworkId to stats#4087

Merged
pmuens merged 2 commits into
masterfrom
UserStatsUpdate
Aug 15, 2017
Merged

Add FrameworkId to stats#4087
pmuens merged 2 commits into
masterfrom
UserStatsUpdate

Conversation

@alexdebrie

Copy link
Copy Markdown
Contributor

Adds FrameworkId to stats calls

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens self-requested a review August 15, 2017 08:06

@pmuens pmuens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @alexdebrie 👍

Just tested this with a create command and it works as expected 👍

Merging :shipit:

@pmuens pmuens merged commit c5762f5 into master Aug 15, 2017
@pmuens pmuens deleted the UserStatsUpdate branch August 15, 2017 10:10
@pmuens pmuens modified the milestone: 1.20 Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants