handle absolute paths in file() by mangas · Pull Request #3888 · serverless/serverless · GitHub
Skip to content

handle absolute paths in file()#3888

Merged
pmuens merged 3 commits into
serverless:masterfrom
mangas:3629-fix-file-absolute-path
Jul 7, 2017
Merged

handle absolute paths in file()#3888
pmuens merged 3 commits into
serverless:masterfrom
mangas:3629-fix-file-absolute-path

Conversation

@mangas

@mangas mangas commented Jul 3, 2017

Copy link
Copy Markdown
Contributor

What did you implement:

Closes #3629

How did you implement it:

How can we verify it:

Todos:

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens self-requested a review July 3, 2017 13:11
@mangas

mangas commented Jul 3, 2017

Copy link
Copy Markdown
Contributor Author

@mangas

mangas commented Jul 6, 2017

Copy link
Copy Markdown
Contributor Author

Any chance I can get a review on this PR ?

@pmuens pmuens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PR @mangas 👍

Just tested it thoroughly today and couldn't break it. Merging once the build passes :shipit:

@mangas

mangas commented Jul 7, 2017

Copy link
Copy Markdown
Contributor Author

@pmuens great news! when do you think the next release will happen?

@pmuens pmuens merged commit c67d60f into serverless:master Jul 7, 2017
@pmuens

pmuens commented Jul 7, 2017

Copy link
Copy Markdown
Contributor

@pmuens great news, when do you think the next release will happen?

@mangas the next release (v1.18) is scheduled for July 19, 2017. However this feature could potentially be available in an upcoming patch release.

@mangas mangas deleted the 3629-fix-file-absolute-path branch July 7, 2017 12:56
@mangas

mangas commented Jul 7, 2017

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants