Add environment variable config to templates by pmuens · Pull Request #2761 · serverless/serverless · GitHub
Skip to content

Add environment variable config to templates#2761

Merged
pmuens merged 1 commit into
masterfrom
add-environment-variable-config-to-templates
Nov 21, 2016
Merged

Add environment variable config to templates#2761
pmuens merged 1 commit into
masterfrom
add-environment-variable-config-to-templates

Conversation

@pmuens

@pmuens pmuens commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

What did you implement:

Add examples to create templates as mentioned by @braahyan in #2748

How did you implement it:

Add commented out examples to serverless.yml templates.

How can we verify it:

Look at the templates

Todos:

  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config/commands/resources
  • Change ready for review message below

Is this ready for review?: YES

@nikgraf

nikgraf commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

@pmuens

pmuens commented Nov 21, 2016

Copy link
Copy Markdown
Contributor Author

@pmuens pmuens merged commit 92e59c3 into master Nov 21, 2016
@pmuens pmuens deleted the add-environment-variable-config-to-templates branch November 21, 2016 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants