meta: retry image pulls in the database start scripts by WikiRik · Pull Request #18340 · sequelize/sequelize · GitHub
Skip to content

meta: retry image pulls in the database start scripts - #18340

Draft
WikiRik wants to merge 2 commits into
mainfrom
meta/retry-image-pulls
Draft

meta: retry image pulls in the database start scripts#18340
WikiRik wants to merge 2 commits into
mainfrom
meta/retry-image-pulls

Conversation

@WikiRik

@WikiRik WikiRik commented Sep 4, 2026

Copy link
Copy Markdown
Member

Pull Request Checklist

  • Have you added new tests to prevent regressions? (N/A - dev tooling)
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? (N/A)
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Docker Hub occasionally answers an image pull with 500 Internal Server Error, which fails the CI job within seconds of the start step beginning. Two recent examples:

  • mariadb oldest (Node 22): mariadb-oldest Error received unexpected HTTP status: 500 Internal Server Error
  • mysql oldest (Node 20): Head "https://registry-1.docker.io/v2/library/mysql/manifests/8.0.19": received unexpected HTTP status: 500 Internal Server Error

This is not dialect-specific, so this PR covers every dialect's start script in one go rather than one PR per dialect.

Changes

  • New dev/pull-images.sh: pulls a compose project's images, retrying up to 3 times (override with PULL_ATTEMPTS) with a 15s/30s delay between attempts.
  • Every dev/*/{oldest,latest}/start.sh calls it before docker compose up -d, so up finds the images already present.

Verification

Scenario Result
Cached image pulled, exit 0
Non-existent tag, PULL_ATTEMPTS=2 two attempts 15s apart, then exit 1 with the registry error shown

Note: this touches the same start.sh files as #18339 (oracle) and the db2 PR, so expect a trivial merge conflict in whichever lands last.

🤖 Generated with Claude Code

Docker Hub occasionally answers an image pull with "500 Internal
Server Error", which fails the CI job within seconds of the start
step beginning. Recent examples: mariadb oldest (Node 22) on #18327
and mysql oldest (Node 20) on #18337.

Pull the compose project's images explicitly before `up -d`, retrying
up to three times with a growing delay, so a transient registry error
no longer fails the whole job.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant