{{ message }}
ci: pin pg-native so the Node 10 postgres-native legs parse - #18314
Open
stuartnelson3 wants to merge 1 commit into
Open
ci: pin pg-native so the Node 10 postgres-native legs parse#18314stuartnelson3 wants to merge 1 commit into
stuartnelson3 wants to merge 1 commit into
Conversation
Closes sequelize#18312. The workflow installed pg-native unpinned, after the lockfile install, so CI always took the newest release. pg-native 3.8.0 added nullish coalescing, which Node 10 cannot parse, and the module threw at load time before mocha ran a single test. Verified under node:10-alpine, Node v10.24.1: `node --check` passes on every js file in pg-native 3.7.0 and fails on 3.8.0 and 3.9.0. The transitive libpq 1.11.0 parses too, and pg-native pins pg-types exactly, so 3.7.0 is enough. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Checklist
npm run testornpm run test-DIALECTpass with this change (including linting)? CI on this pull request is the test.Description Of Change
Closes #18312.
The workflow installs
pg-nativeunpinned, after the lockfile install, so CI always takesthe newest release:
pg-native3.8.0 added nullish coalescing, which Node 10 cannot parse, so the module throwsat load time before mocha runs a single test. That takes out four legs of the
test-postgresmatrix on every pull request against
v6:This pins the version. The Node 10 legs are the reason a pin is needed, and I pinned all
nativelegs rather than only the Node 10 ones, so the matrix stays uniform and no legdepends on whatever npm publishes next.
Verification
Under
node:10-alpine, Node v10.24.1,node --checkon every.jsfile in each package:pg-native@3.7.0pg-native@3.8.0SyntaxError: Unexpected token ?pg-native@3.9.0SyntaxError: Unexpected token ?libpq@1.11.0, the version 3.7.0 resolvespg-nativepinspg-typesto an exact version, andlibpqabove is the resolvedtransitive, so 3.7.0 is enough on its own. The native build itself was never the problem:
the Node 10 legs today get through install and fail at test time.
I could not run the native suite locally, because
libpqneeds headers this machine does nothave. CI on this pull request covers that.
Alternative I did not take
Adding
pg-nativetodevDependencieswould let--frozen-lockfilegovern it and end thisclass of failure for good. I left it alone, because every leg and every contributor would
then build
libpqfrom source, and only the fournativelegs need it.