ci: pin pg-native to 3.7.0 for Node 10 compatibility by lazerg · Pull Request #18313 · sequelize/sequelize · GitHub
Skip to content

ci: pin pg-native to 3.7.0 for Node 10 compatibility - #18313

Open
lazerg wants to merge 1 commit into
sequelize:v6from
lazerg:fix/issue-18312-pin-pg-native
Open

ci: pin pg-native to 3.7.0 for Node 10 compatibility#18313
lazerg wants to merge 1 commit into
sequelize:v6from
lazerg:fix/issue-18312-pin-pg-native

Conversation

@lazerg

@lazerg lazerg commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

The native legs of test-postgres install pg-native unpinned, so they now pull 3.8.0+, which uses ?? in Client.prototype.getTransactionStatus. Node 10 cannot parse that, require('pg-native') throws at module load, and the four Node 10 native jobs end up running no tests at all.

3.7.0 is the last release Node 10 can read, and pg 8.11.0 (the version the lockfile pins) never calls getTransactionStatus, so pinning it costs nothing here.

Closes #18312

List of Breaking Changes

None.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant