{{ message }}
fix: validate session variable assignments - #18290
Merged
Merged
Conversation
Backport of #18272 to v6. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
pg-native 3.8.0 uses `??`, which Node 10 cannot parse, so requiring it throws a SyntaxError before any test runs. Node 18 keeps using the current release. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
WikiRik
enabled auto-merge (squash)
July 29, 2026 13:27
Member
Author
|
@denyspakizh-tob what do you think about this PR? |
WikiRik
disabled auto-merge
July 29, 2026 18:04
WikiRik
pushed a commit
that referenced
this pull request
Jul 29, 2026
pg-native 3.8.0 uses `??`, which Node 10 cannot parse, so requiring it throws a SyntaxError before any test runs. Pin the last release Node 10 can load and keep newer Node versions on the current one. Ported from #18290 so that the backport there stays limited to its own change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
SippieCup
self-requested a review
August 15, 2026 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18272 to v6.
sequelize.set()builds itsSETstatement by interpolating both keys and values directly. Values now go through the normal escaping path, and names are validated against the 1-64 character unquoted user-variable grammar.Added unit coverage for the generated SQL and integration coverage for the round-trip.
Also pins
pg-nativeto 3.7.0 on the Node 10 legs of the Postgres matrix. 3.8.0 uses??, which Node 10 cannot parse, so requiring it throws aSyntaxErrorbefore any test runs. This is unrelated to the backport and was already failing onv6.List of Breaking Changes
Quoted user-variable names, such as
`my var`,'x', or"x", are now rejected. Use an unquoted name matching the supported grammar.🤖 Generated with Claude Code