{{ message }}
fix(types): align ValidationErrorItem typings with runtime (v6 backport)#18159
Open
abdelrahmanSheref101 wants to merge 2 commits intosequelize:v6from
Open
fix(types): align ValidationErrorItem typings with runtime (v6 backport)#18159abdelrahmanSheref101 wants to merge 2 commits intosequelize:v6from
abdelrahmanSheref101 wants to merge 2 commits intosequelize:v6from
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Checklist
No — this change is a typing/runtime alignment; existing tests pass. I can add a test if maintainers want one.
No — not required for this small typings fix.
Yes — updated
ValidationErrorItemTypeand the constructor behavior so generated.d.tsmatches runtime.No issue link — described the problem below.
Yes —
fix(types): align ValidationErrorItem typings with runtime (v6 backport).Description of Changes
The published v6 package shipped
.d.tswith lowercase enum keys while runtime throws capitalized type strings (e.g."notNull Violation","Validation error"). This caused a mismatch for TypeScript consumers.This PR backports a minimal, safe fix for v6:
ValidationErrorItemTypeenum to use the canonical runtime keys (so generated.d.tsreflects what is actually thrown).ValidationErrorItemconstructor accept type strings case-insensitively and preserve the original passed form inthis.type, while mapping to the canonicaloriginvalue internally.Files changed:
packages/core/src/errors/validation-error.ts(enum + constructor logic)Behavior:
.d.tsnow matches runtime values, so TypeScript consumers on v6 get correct typings.List of Breaking Changes
Testing / How I verified
Locally:
yarn install --immutable yarn build yarn testIf you prefer, I can add a small unit/integration test asserting
ValidationErrorItem.typefor the specific cases; otherwise this remains a focused, low-risk backport.If you want I can also attach the
diff -uoutput (pack vs. built) to the PR comments.