fix(count): fix null count with includes by papb · Pull Request #11295 · sequelize/sequelize · GitHub
Skip to content

fix(count): fix null count with includes#11295

Merged
sushantdhiman merged 2 commits into
sequelize:masterfrom
papb:fix-issue-7931
Aug 11, 2019
Merged

fix(count): fix null count with includes#11295
sushantdhiman merged 2 commits into
sequelize:masterfrom
papb:fix-issue-7931

Conversation

@papb

@papb papb commented Aug 8, 2019

Copy link
Copy Markdown
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fix #7931

@papb papb added type: bug DEPRECATED: replace with the "bug" issue type status: awaiting maintainer labels Aug 8, 2019
@papb papb changed the title # fix(count): fix null count with includes fix(count): fix null count with includes Aug 8, 2019
@sushantdhiman sushantdhiman merged commit 592099d into sequelize:master Aug 11, 2019
@sushantdhiman

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released type: bug DEPRECATED: replace with the "bug" issue type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

findAndCount doesn't return a count when passed raw:false and includes

2 participants