{{ message }}
Fix dataSources to count normal errors#129
Merged
Merged
Conversation
Member
Author
disktnk
reviewed
Jan 5, 2017
| So(<-stopped, ShouldBeNil) | ||
|
|
||
| Convey("Then numError should be increased", func() { | ||
| So(srcs.numErrors, ShouldEqual, 1) |
Member
There was a problem hiding this comment.
I think that it is better to confirm srcs.numErrors equals 0 before written, and talk with nobu-k, the test suite has an implicit premise that srcs is initialized with srcs.numErrors = 0
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
dataSourcesin pipe.go, fatal and temporary errors were correctly counted, but normal errors were not.