Add get events method by demoore · Pull Request #82 · sendwithus/sendwithus_ruby · GitHub
Skip to content

Add get events method#82

Merged
demoore merged 2 commits into
masterfrom
add-get-events-method
Nov 16, 2018
Merged

Add get events method#82
demoore merged 2 commits into
masterfrom
add-get-events-method

Conversation

@demoore

@demoore demoore commented Nov 16, 2018

Copy link
Copy Markdown
Member

Description

Add a log_events method so events can be retrieved for an individual log.

Motivation and Context

Fixes issue #81 and brings this more inline with the Sendwithus PHP client.

How Has This Been Tested?

Tests have been added. This has also been tested locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@demoore demoore self-assigned this Nov 16, 2018
@demoore demoore requested review from Bean0B and phil-ma November 16, 2018 23:29
@demoore demoore requested a review from a team as a code owner November 16, 2018 23:29

@phil-ma phil-ma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @demoore! Looks good 👍

@demoore demoore merged commit 5022ade into master Nov 16, 2018
@demoore demoore deleted the add-get-events-method branch November 16, 2018 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants