{{ message }}
Exclude test package#300
Merged
Merged
Conversation
Contributor
thinkingserious
added
status: code review request
Contributor
|
Hi @irushchyshyn, I think this is a good solution, could you please sign our CLA so I can merge it? Thanks! |
Contributor
Author
|
Thanks for review @thinkingserious ! CLA signed and sent. |
|
Yesterday, we launched a new, much easier CLA system. All you need to now is click a button and you are done! Please take a moment to do so here. Thanks! With Best Regards, Elmer |
Contributor
Author
|
Thanks @SendGridDX ! Done. |
Sendgrid tests are installed into `<python_sitelib>/test` which may cause conflicts with other packages. We have run into this when building a package for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1309244) The solution would be to either exclude tests or install them under sendgrid directory (`<python_sitelib>/sendgrid/test`).
|
|
thinkingserious
added a commit
that referenced
this pull request
Mar 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sendgrid tests are installed into
<python_sitelib>/testwhich may cause conflicts with other packages. We have run into this when building a package for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=1309244)The solution would be to either exclude tests or install them under sendgrid directory (
<python_sitelib>/sendgrid/test).