Monorepo by adamreisnz · Pull Request #407 · sendgrid/sendgrid-nodejs · GitHub
Skip to content

Monorepo#407

Merged
thinkingserious merged 85 commits into
sendgrid:masterfrom
adamreisnz:monorepo
Aug 28, 2017
Merged

Monorepo#407
thinkingserious merged 85 commits into
sendgrid:masterfrom
adamreisnz:monorepo

Conversation

@adamreisnz

@adamreisnz adamreisnz commented Jul 19, 2017

Copy link
Copy Markdown
Contributor

@thinkingserious PR from monorepo to master

@thinkingserious

Copy link
Copy Markdown
Contributor

@adamreisnz

Copy link
Copy Markdown
Contributor Author

@thinkingserious There was an issue with the merge data helper, I've fixed this in 3be7fd8

@thinkingserious

Copy link
Copy Markdown
Contributor

I'm not quite sure why those final two tests are failing. Locally, they work fine. I'll dig deeper.

@thinkingserious thinkingserious merged commit dad53e8 into sendgrid:master Aug 28, 2017
@adamreisnz

Copy link
Copy Markdown
Contributor Author

Awesome thanks for the release! Look forward to ongoing developments of this package.
Did you deprecate the old package on npm?

@thinkingserious

Copy link
Copy Markdown
Contributor

@adamreisnz,

I did not, but now I have :)

Thanks for the heads up!

@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @adamreisnz,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@adamreisnz

Copy link
Copy Markdown
Contributor Author

@adamreisnz adamreisnz deleted the monorepo branch August 31, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants