Fill 'response' property in error instance by sitegui · Pull Request #299 · sendgrid/sendgrid-nodejs · GitHub
Skip to content

Fill 'response' property in error instance#299

Merged
thinkingserious merged 1 commit into
sendgrid:masterfrom
sitegui:responseInError
Sep 27, 2016
Merged

Fill 'response' property in error instance#299
thinkingserious merged 1 commit into
sendgrid:masterfrom
sitegui:responseInError

Conversation

@sitegui

@sitegui sitegui commented Sep 19, 2016

Copy link
Copy Markdown

This makes the behavior when using callbacks consistent with the promise counterpart.
That is, in both cases, error.response is present

This makes the behavior when using callbacks consistent with
the promise counterpart
@sitegui

sitegui commented Sep 19, 2016

Copy link
Copy Markdown
Author

@thinkingserious

Copy link
Copy Markdown
Contributor

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: cla needed and removed status: cla needed labels Sep 22, 2016
@thinkingserious thinkingserious merged commit 05c3b3d into sendgrid:master Sep 27, 2016
shkabo pushed a commit to shkabo/sendgrid-nodejs that referenced this pull request Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants