All destinations by breadchris · Pull Request #152 · scratchdata/scratchdata · GitHub
Skip to content

All destinations#152

Merged
poundifdef merged 40 commits intoscratchdata:mainfrom
breadchris:all-destinations-151
Apr 10, 2024
Merged

All destinations#152
poundifdef merged 40 commits intoscratchdata:mainfrom
breadchris:all-destinations-151

Conversation

@breadchris
Copy link
Copy Markdown
Contributor

#151

This generalizes how the destinations are configured:

  • bigquery
  • clickhouse
  • duckdb
  • redshift

Comment thread pkg/destinations/bigquery/bigquery.go Outdated
@breadchris breadchris marked this pull request as ready for review April 8, 2024 23:15
@poundifdef
Copy link
Copy Markdown
Contributor

@poundifdef
Copy link
Copy Markdown
Contributor

poundifdef commented Apr 9, 2024

The "request a connection" UI does not work.

@poundifdef
Copy link
Copy Markdown
Contributor

When I request a connection, the request is always set to DuckDB no matter what database type I choose.

Comment thread pkg/view/router.go Outdated
@poundifdef
Copy link
Copy Markdown
Contributor

@poundifdef poundifdef merged commit 18cdcf2 into scratchdata:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants