{{ message }}
Migrate to pyproject.toml-based configuration#1088
Merged
Conversation
- Remove setup.py (redundant with pyproject.toml) - Move .flake8 config to [tool.flake8] in pyproject.toml - Add [tool.isort] and [tool.black] config for consistency - Remove setup.py from bumpversion file list - Update VERSION_MANAGEMENT.md to reflect changes
Remove references to deleted files (setup.py, .flake8, .bumpversion.cfg) and update pyproject.toml description to mention it contains all tool config.
The .flake8 file was consolidated into pyproject.toml, but the tester Dockerfile still tried to copy it. Flake8 6.0+ reads config from pyproject.toml natively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the project configuration by migrating from legacy setup files to a unified
pyproject.tomlconfiguration. This aligns with current Python packaging best practices and simplifies project maintenance.Key Changes
Removed legacy configuration files:
setup.py- all package metadata now defined inpyproject.toml.flake8- linting configuration moved topyproject.tomlConsolidated tool configurations in
pyproject.toml:[tool.flake8]sectionprofile = "black",line_length = 120)line-length = 120)Updated version management:
setup.pyfrom bumpversion file trackingVERSION_MANAGEMENT.mdto reflect that version bumping now only updatespyproject.tomlandscoring_engine/version.pypyproject.tomlconfiguration instead of.bumpversion.cfgBenefits
pyproject.tomlpyproject.tomlsupport