{{ message }}
Let subprocess launched by run handle its own sigint#246
Merged
Conversation
Member
Author
|
OK, will dig a bit further. |
Member
Author
|
Hopefully got it this time! |
|
Tests supposed to be failing? |
Member
Author
No, it's on Windows only, will see why; Windows probably doesn't support preexec_fn. |
|
But I can confirm this fixes the issue nicely in linux at least. |
Member
Author
|
Alternative approach to try: try:
process.wait()
except KeyboardInterrupt:
print("Terminating subprocess...")
parent = psutil.Process(process.pid)
for child in parent.children(recursive=True):
child.kill()
process.wait() |
|
I think I like this as is now, we shouldn't decide for the process that sigint should kill it. If the process wants to do a dance on that signal, it's free to do so 😁 |
Member
Author
|
I just need to fire up my Windows test machine, then I can see if it works on that platform as well. |
Otherwise, the subprocess is aborted by the parent process. This change makes `spin run python -i ...` usable. Closes scientific-python#235
stefanv
force-pushed
the
avoid-capturing-sigint
branch
from
45d2cb6 to
5c0a79d
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the subprocess is aborted by the parent process. This change makes
spin run python -i ...usable.Closes #235
/cc @adrinjalali