Clarify error message when executed binary not found by stefanv · Pull Request #237 · scientific-python/spin · GitHub
Skip to content

Clarify error message when executed binary not found #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanv merged 1 commit into from
Sep 23, 2024
Merged

Clarify error message when executed binary not found #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions spin/cmds/meson.py
View file
Open in desktop
8 changes: 6 additions & 2 deletions spin/cmds/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,16 @@ def run(
print(f"Failed to launch `{cmd}`")
sys.exit(-1)
else:
p = subprocess.run(cmd, *args, **kwargs)
try:
p = subprocess.run(cmd, *args, **kwargs)
except FileNotFoundError:
click.secho(f"`{cmd[0]}` executable not found. Exiting.", fg="bright_red")
raise SystemExit(1) from None
if p.returncode != 0 and sys_exit:
# Output was suppressed, but the process failed, so print it anyway
if output is False:
print(p.stdout.decode("utf-8"), end="")
sys.exit(p.returncode)
raise SystemExit(p.returncode)
return p


Expand Down
10 changes: 10 additions & 0 deletions spin/tests/test_util.py
View file
Open in desktop