{{ message }}
Allow X-Requested-With with value XMLHttpRequest over XmlHttpRequest#109
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the value of the X-Requested-With header from XmlHttpRequest to XMLHttpRequest to align with the standard convention used by JavaScript libraries like jQuery. The change ensures proper detection of AJAX requests.
- Updates the header value check in the middleware from
XmlHttpRequesttoXMLHttpRequest - Updates corresponding test cases to use the corrected header value
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Middleware/Mezzio.php | Updates the X-Requested-With header value check from 'XmlHttpRequest' to 'XMLHttpRequest' |
| spec/Middleware/MezzioSpec.php | Updates four test cases to use the corrected 'XMLHttpRequest' header value |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
samsonasik
changed the title
samsonasik
changed the title
samsonasik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference: