googleauth: RHEL support by unilogicbv · Pull Request #229 · saltstack-formulas/users-formula · GitHub
Skip to content

googleauth: RHEL support - #229

Open
unilogicbv wants to merge 7 commits into
saltstack-formulas:masterfrom
unilogicbv:google_auth
Open

unilogicbv wants to merge 7 commits into
saltstack-formulas:masterfrom
unilogicbv:google_auth

Conversation

@unilogicbv

@unilogicbv unilogicbv commented Jun 13, 2022 •

Copy link
Copy Markdown
Contributor

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

Related issues and/or pull requests

Describe the changes you're proposing

1dcd7d5 is a small refactor, which provides groundwork for RHEL support, without actually adding any RHEL specific changes.
52c3520 adds RHEL (and derivatives) support

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Tested on Ubuntu 20.04, CentOS 7 and Rocky 8.

@myii

myii commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

@unilogicbv
unilogicbv requested a review from a team as a code owner June 14, 2022 09:31
@unilogicbv
unilogicbv force-pushed the google_auth branch 2 times, most recently from 8a3c915 to 0db0cde Compare June 14, 2022 11:59
@unilogicbv

Copy link
Copy Markdown
Contributor Author

Is there anything I need to clarify in order to get this pull request reviewed?

@opserve-menno

Copy link
Copy Markdown

opserve-menno added a commit to opservenl/users-formula that referenced this pull request May 12, 2023
This merges pull request saltstack-formulas#229 (googleauth: RHEL support)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants