iframe-proxy

estebanthi · 2025-07-01T13:47:28Z

Provide context when generating enum names to avoid ending up with duplicate enums with wrong values.

Summary by Sourcery

Introduce model-context-aware enum name generation to prevent naming collisions by passing model context into property parsing and using a new helper method.

Bug Fixes:

Fix duplicate enum class names by including model context in enum naming to ensure enums have the correct values.

Enhancements:

Add _create_unique_enum_name method to build enum class names from combined model and property names.
Pass model_context argument to _parse_property when parsing both models and request models.
Replace direct enum name formatting with calls to _create_unique_enum_name in array and simple enum parsing.

sourcery-ai · 2025-07-01T13:47:32Z

Reviewer's Guide

Introduces a new helper method to generate unique enum class names by combining model context and property names, and updates parsing logic to pass model context and replace inline enum name formatting with this helper.

Class diagram for updated enum name generation in model parser

classDiagram
    class Parser {
        _parse_model(name, schema)
        _parse_property(original_name, schema, required, model_context="")
        _create_unique_enum_name(property_name, model_context="")
    }
    Parser : +_parse_model(name, schema)
    Parser : +_parse_property(original_name, schema, required, model_context="")
    Parser : +_create_unique_enum_name(property_name, model_context="")
    Parser : -to_pascal_case(name)
    Parser : -to_snake_case(name)
    Parser : -_handle_exception(msg, e)
    Parser : -_parse_operation_swagger2(path, method, operation)
    Parser : -_create_request_model(model_name, parameters)

    Parser --> "uses" _create_unique_enum_name
    Parser --> "calls" _parse_property
    Parser --> "calls" _parse_model
    Parser --> "calls" _create_request_model
    Parser --> "calls" _parse_operation_swagger2

Flow diagram for unique enum name generation

flowchart TD
    A[Start parsing model] --> B{Property has enum?}
    B -- Yes --> C[Call _create_unique_enum_name with property name and model context]
    C --> D[Assign unique enum name to property]
    B -- No --> E[Continue parsing]
    D --> E
    E --> F[Finish parsing model]

File-Level Changes

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Handle duplicate enum names in models

04e30d7

saleweaver merged commit 122772c into saleweaver:v2-01 Jul 1, 2025
1 check passed

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Handle duplicate enum names in models#1802

Handle duplicate enum names in models#1802
saleweaver merged 1 commit into
saleweaver:v2-01from
estebanthi:f/handle_duplicate_enum_names

estebanthi commented Jul 1, 2025 •

edited by sourcery-ai Bot

Loading

Uh oh!

sourcery-ai Bot commented Jul 1, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

estebanthi commented Jul 1, 2025 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for updated enum name generation in model parser

Flow diagram for unique enum name generation

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

estebanthi commented Jul 1, 2025 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Jul 1, 2025 •

edited

Loading