Made compatible with last bioptim version by fbailly · Pull Request #3 · s2mLab/BioptimPaperExamples · GitHub
Skip to content

Made compatible with last bioptim version#3

Merged
pariterre merged 8 commits into
s2mLab:mainfrom
fbailly:main
Nov 9, 2021
Merged

Made compatible with last bioptim version#3
pariterre merged 8 commits into
s2mLab:mainfrom
fbailly:main

Conversation

@fbailly

@fbailly fbailly commented May 6, 2021

Copy link
Copy Markdown
Contributor

Should be merged in a branch called something like "bioptim_updated"

@fbailly fbailly changed the title Made compatible with last bioptim version [WIP] Made compatible with last bioptim version May 6, 2021
@fbailly

fbailly commented May 7, 2021

Copy link
Copy Markdown
Contributor Author

@fbailly

fbailly commented May 8, 2021

Copy link
Copy Markdown
Contributor Author

@fbailly fbailly changed the title [WIP] Made compatible with last bioptim version Made compatible with last bioptim version May 8, 2021

@pariterre pariterre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • two minor comments
    AND
  • Should we update the MHE example so it fits the new API? @aceglia you may take this opportunity to familiarize yourself with the bioptim MHE API?

Comment thread jumper/jumper/ocp.py
Comment on lines +174 to +175
self.constraints.add(maximal_tau, phase=i, node=Node.ALL, minimal_tau=self.tau_min,
get_all_nodes_at_once=True)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we black?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ma57 and print_level=0 gives highly misleading error message. I fear this will lead to think that the examples are broken (instead of their installation is wrong...)

@pariterre pariterre merged commit bb3cf20 into s2mLab:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants