{{ message }}
Speed up applying the permutation in sort-axis example#930
Merged
Conversation
Speed it up by avoiding bounds checking when looking up the pane to move in the source array. This works because for any given element pointer in the array we have the relationship: .index_axis(axis, 0) + .stride_of(axis) * j == .index_axis(axis, j) where + is pointer arithmetic on the element pointers.
bluss
commented
Mar 3, 2021
Member
Author
There was a problem hiding this comment.
coding style wise this is a bit ugh, since it depends on manual pointer offsetting instead of using an abstraction. Probably this would be ok as an implementation but not great as an example and that's where it is now.
Member
There was a problem hiding this comment.
Yeah, I've never really thought this was a great example to showcase the library, although I'm not sure where else to put it. I do think it would be worth considering adding some of this functionality to ndarray itself.
Member
Author
There was a problem hiding this comment.
yes, of course, it's just that it needs API design to be added to ndarray
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed it up by avoiding bounds checking when looking up the pane to move
in the source array.
This works because for any given element pointer in the array we have the
relationship:
.index_axis(axis, 0) + .stride_of(axis) * j == .index_axis(axis, j)
where + is pointer arithmetic on the element pointers.