Fix CI by suppressing clippy::manual_non_exhaustive warning by rhysd · Pull Request #828 · rust-ndarray/ndarray · GitHub
Skip to content

Fix CI by suppressing clippy::manual_non_exhaustive warning#828

Closed
rhysd wants to merge 1 commit into
rust-ndarray:masterfrom
rhysd:suppress-non-exhaustive-enum-warning
Closed

Fix CI by suppressing clippy::manual_non_exhaustive warning#828
rhysd wants to merge 1 commit into
rust-ndarray:masterfrom
rhysd:suppress-non-exhaustive-enum-warning

Conversation

@rhysd

@rhysd rhysd commented Jul 1, 2020 •
edited
Loading

Copy link
Copy Markdown

CI is failing since clippy raises a warning:

error: this seems like a manual implementation of the non-exhaustive pattern
  --> src/error.rs:37:1
   |
37 |   pub enum ErrorKind {
   |   ^-----------------
   |   |
   |  _help: add the attribute: `#[non_exhaustive] pub enum ErrorKind`
   | |
38 | |     /// incompatible shape
39 | |     IncompatibleShape = 1,
40 | |     /// incompatible memory layout
...  |
51 | |     __Incomplete,
52 | | }
   | |_^
   |
   = note: `-D clippy::manual-non-exhaustive` implied by `-D warnings`
help: remove this variant
  --> src/error.rs:51:5
   |
51 |     __Incomplete,
   |     ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_non_exhaustive

https://travis-ci.org/github/rust-ndarray/ndarray/jobs/702749109

However, #[non_exhaustive] attribute is not available because Rust 1.37.0, which seems MSRV of this library, did not stabilize the attribute.

For now, I think clippy::manual-non-exhaustive should be suppressed until the attribute is available by bumping up MSRV.

@ZuseZ4

ZuseZ4 commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

@xd009642

xd009642 commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

Yeah, I'd agree to up the MSRV and and bump the minor version for the next release.

@xd009642

xd009642 commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

Oh also in the docs we've promised to up the MSRV with this line 😉

The crate is continuously developing, and breaking changes are expected during evolution from version to version. We adopt the newest stable rust features if we need them.

@ZuseZ4 ZuseZ4 mentioned this pull request Nov 11, 2020
Merged
@ZuseZ4

ZuseZ4 commented Nov 28, 2020

Copy link
Copy Markdown
Contributor

Can be closed due to
Duplicate of #848

@bluss bluss closed this Nov 28, 2020
@bluss

bluss commented Nov 28, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhysd @ZuseZ4 @xd009642 @bluss