{{ message }}
Add .reborrow() methods to array views#412
Merged
Merged
Conversation
`ArrayView<'a, T, D>` is invariant in parameters `T` and `'a`, because `ArrayBase<S, D>` is invariant in the parameter `S` because the array base is using the projection `<S as Data>::Elem` in the struct definition. This means that the equivalent of the `&'a T -> &'b T` conversion (valid whenever `'a: 'b` is not naturally available for array views; we can provide it manually, with a method.
Member
Author
Member
|
"reborrow" seems like a good name to me. You are effectively borrowing the data again; the For those not on IRC, this was the case that caused me to encounter the issue. I did find that calling |
|
I was really in need of this API some time ago. Thanks for introducing it! :) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayView<'a, T, D>is invariant in parametersTand'a, becauseArrayBase<S, D>is invariant in the parameterSbecause the arraybase is using the projection
<S as Data>::Elemin the structdefinition.
This means that the equivalent of the
&'a T -> &'b Tconversion (validwhenever
'a: 'bis not naturally available for array views; we canprovide it manually, with a method.