{{ message }}
feat: add native deletion support for identity removal in gzip files#6896
Open
feat: add native deletion support for identity removal in gzip files#6896
Conversation
2476490 to
220d0ea
Compare
🔒 Scanned for secrets using gitleaks 8.28.0
220d0ea to
1182fb9
Compare
ktgowtham
approved these changes
Apr 22, 2026
Contributor
ktgowtham
left a comment
There was a problem hiding this comment.
LGTM. as long as s3 and s3 data lake has the data in the format that this PR expects. assuming we tested that too.
🔒 Scanned for secrets using gitleaks 8.28.0
achettyiitr
approved these changes
Apr 23, 2026
fracasula
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
GZIPLocalFileHandler.RemoveIdentityusesexec("bash -c sed ...")to strip suppressed user records from an NDJSON gzip file. Two problems with that:regexp.QuoteMeta, but those quotes regex metacharacters — it does not escape shellmetacharacters. Inputs like
$(...)or backticks remain risky.As part of this change, we are using a feature flag and adding native Go support for removing identity. we will be iterating line by line and deleting the lines that have the suppressed userIDs.
Benchmarks
Linear Ticket
pipe-2904
Security