{{ message }}
fix(grep): skip redundant header on single-match results#2619
Open
guyoron1 wants to merge 1 commit into
Open
Conversation
The summary header "N matches in M files:" was always emitted, even for single-match results where it adds no value and wastes tokens. Now the header is suppressed when there is exactly 1 match in 1 file. Also fixes grammar: "1 matches" → "1 match", "1 files" → "1 file". Closes rtk-ai#2608
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2608 —
rtk grepemitted a redundant"N matches in M files:"header even for single-match results."1 matches in 1 files"→"1 match in 1 file"for all remaining casesBefore / After
1 matches in 1 files:\n\nsrc/main.rs:42:...src/main.rs:42:...3 matches in 1 files:\n\n...3 matches in 1 file:\n\n...2 matches in 2 files:\n\n...2 matches in 2 files:\n\n...(unchanged)Test plan
cargo fmt --allpassescargo clippy --all-targetspasses (zero warnings)cargo test --allpasses (all tests)