{{ message }}
perf(tracking): gate cleanup_old behind 24h interval#2615
Open
guyoron1 wants to merge 1 commit into
Open
Conversation
cleanup_old() ran two DELETE scans on every record() call, adding ~7ms of synchronous SQLite I/O to every command. Gate it behind a meta table timestamp so it runs at most once per 24 hours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #2208
cleanup_old()ran twoDELETE ... WHERE timestamp < ?scans on everyrecord()andrecord_parse_failure()call, adding ~7ms of synchronous SQLite I/O to every RTK command — violating the <10ms startup target.This PR gates cleanup behind a 24-hour interval using a new
metakey-value table:record()call, a singleSELECTon the 1-rowmetatable checkslast_cleanup(~0.05ms)Performance impact:
Changes:
CLEANUP_INTERVAL_HOURSconstant (24h) toconstants.rsmetatable (key TEXT PRIMARY KEY, value TEXT) in schema setupcleanup_old()withmaybe_cleanup()— checkslast_cleanuptimestamp before running DELETEslet _ =for cleanup calls (INSERT already succeeded; cleanup failure shouldn't break recording)Test plan
cargo fmt --all— no issuescargo clippy --all-targets— zero warningscargo test --all— all 2246 tests passtest_maybe_cleanup_skips_when_recent— verifies old records survive when last_cleanup is freshtest_maybe_cleanup_runs_when_stale— verifies old records are deleted when last_cleanup >24h ago