{{ message }}
fix(hook): apply exclude_commands to head/tail rewrites#2612
Open
guyoron1 wants to merge 1 commit into
Open
Conversation
The head/tail short-circuit in rewrite_segment_inner returned a rewrite before reaching the exclusion check, so hooks.exclude_commands entries for head/tail were silently ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewrite_segment_innerreturned a rewrite before reaching the exclusion check, sohooks.exclude_commandsentries for head/tail were silently ignoredis_excluded()check before therewrite_line_range()call, matching the pattern used by other commands in the same functionFixes #2363
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testheadtohooks.exclude_commandsin config, verifyhead -20 fileis no longer rewritten