{{ message }}
Update Pydantic usage for v2 compatibility #185
Merged
Merged
Conversation
Contributor
Author
All changes are internal. The main changes are in prototypes and API errors. Prototypes now are created from dictionaries of tuples of (type, value). API errors are now a list of dictionaries, giving the type, location, error message, erroneous input, and a url to pydantic's website with more about the error.
Contributor
Author
|
For now, spacy is not compliant with pydantic v2. These changes will give some deprecation warnings in tests, but overall are v1 and v2 compatible. |
isabelizimm
changed the title
isabelizimm
commented
Jul 26, 2023
| python -m pip install xgboost | ||
| python -m pip install spacy | ||
| python -m pip install torch | ||
| python -m pip install statsmodels |
Contributor
Author
There was a problem hiding this comment.
this is effectively the same as python -m pip install -e ".[dev,all_models]", but Python 3.7 will not complete installation, ending in an OSError saying there is not enough space 😩 this is likely due to some pretty intense dependency resolution.
I'll likely want to rethink this strategy, but that can come in a separate PR.
isabelizimm
commented
Jul 26, 2023
Contributor
Author
There was a problem hiding this comment.
Pinned due to fastapi requirements. fastapi/fastapi#9808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #184